Wrong aspect ratio on a Samsung Galaxy Note 10.1 (SM-P601) #18
Comments
|
please edit this ticket and include as many details as possible like:
If you can share your url, it would be even better. |
|
@martinbonnin ok, i will share them soon.... |
|
@martinbonnin i have edited it besides this am getting dropped Frames. Here is log for the same: 09-04 17:43:47.311: W/AHierarchicalStateMachine(4304): Warning message AMessage(what = 'omx ', target = 7) = { 09-04 18:00:33.431: D/NAL(5467): profile_idc: 100 09-04 18:01:17.171: E/MediaCodecAudioTrackRenderer(5467): Discontinuity detected [expected 9621333, got 0] |
|
Nice bollywood trailer :-). Works fine on my nexus 5. What device are you testing with ? |
|
haha, thanks. WIll give you more :) works fine with my Nexus 5 too. But i need this on tablet. One thing i noticed is that the surface is displaying a video larger than it should. Can i maintain the aspect ratio as per me in the start only. |
martinbonnin
changed the title
|
I am a bit limited in terms of devices for testing right now (basically I have a nexus 5 and a bunch of low cost phones running jelly bean). I'll try to get my hands on more of them and let you know. |
|
@martinbonnin Thanks a lot. I am a lot dependent on this. And i ll keep studying it. Thanks a lot for all the support... You rock, Cheers |
|
I have a Galaxy Note 10.1 -- I'll take a look. |
|
The video does not appear distorted on my tablet (SM-P600). Here's a screenshot: |
|
I've been able to reproduce this. It happens with 480p video only on my side. It looks like the native MediaPlayer will report dimensions of [872, 480], while exoplayer reports dimensions of [720, 480]. The result is that using exoplayer causes the video to be stretched. I'm still looking into why the dimensions are different. EDIT: The problem is likely that we do not correctly handle non-square pixel formats. We should be able to get the sample aspect ratio from the VUI data. I'm looking into it. |
|
@martinbonnin I have resolved this issue in my fork, although I'm not 100% sure it will work everywhere. The SPS parsing will now extract the aspect ratio and adjust the width / height accordingly. However, there was an issue with the codec reverting to the dimensions indicated in the SPS data (without adjusting for non-square pixel aspect ratio), even though it was being configured with the correct, adjusted dimensions. In order to get around that, I have saved a copy of the MediaFormat which is passed to configureCodec(), and I use it after the fact to extract the adjusted dimensions. This may be dangerous depending on the stream contents -- I'm really not sure. However, my tests have all worked great. I've opened a pull request, so you can check it out: #25 |
|
@martinbonnin hey, did you have a look in to the fix by fougere - mike. Is it going to be stable? |
|
Not sure yet.. The aspect ratio extraction looks good to me. Whether we should send that to the MediaCodec API is another question and I'm not sure there. I would expect the API to be 'aspect ratio agnostic' but maybe I am wrong. |
martinbonnin
changed the title
|
I don't have a nexus 5 to test with, but it was affecting my nexus 7 devices as well as the samsungs. |
|
I am confused. When testing with this url (http://vod.hdi.cdn.ril.com/vod/_definst_/smil:hdivod/4/284/0_y74kwawj.smil/playlist.m3u8), I get the following streams:
So nothing close to 480p and everything with square pixels... Do I miss something ? |
|
@fougere-mike i tried it with your code, but it's still the same for me. Could you give me the test url with which you tested it? Here is the screen shot of what i am getting. |
|
I'm afraid, we have 2 bugs here. One is a corrupted video, other is a aspect ratio problem. @hiteshgupta33 Are you sure you gave us the correct link ? http://vod.hdi.cdn.ril.com/vod/_definst_/smil:hdivod/4/284/0_y74kwawj.smil/playlist.m3u8 is the 'happy new year' trailer and I cannot locate the scene in your screenshot. |
|
@martinbonnin oh that was the correct link. This screen shot is from another video again a anamorphic video. So, basically this problem is with all the content. So basically, we have constant width and variant height. |
|
@martinbonnin Agreed, there are definately 2 different issues here. |
|
@fougere-mike @martinbonnin What can we do about the corrupted video. ? |
|
@hiteshgupta33 so far, we have been unable to reproduce your bug so it's difficult to investigate it. |
|
@martinbonnin I guess @fougere-mike was able to reproduce this issue. |
|
@martinbonnin Ok, sounds good. @hiteshgupta33 Unfortunately, I may have jumped the gun on that one. I was able to create a situation where the video appeared distorted (stretched), and assumed from your description it was the same problem. However, from your recent comments and screenshot it appears our issues were not the same. I have not seen any video corruption akin to your last screenshot. |
|
@fougere-mike oh, that can be the case. So, with the url i gave you, it doesn't distort at your end like the way i have showed in my screenshot. |
|
@martinbonnin @fougere-mike hey guys, i think they fixed it for DASH. @martinbonnin they have fixed the issue you referred it to to the exoplayer issues. Can we do a similar thing? |
|
@hiteshgupta33 they fixed the aspect ratio issue. Your problem is corrupted frames. It has nothing to do with aspect ratio. |
|
@martinbonnin what do you think should be done to fix corrupted frames issue? |
|
@hiteshgupta33 we need to reproduce the issue. |
|
@martinbonnin can i help in that? i am sure i can ;) |
|
I don't have a note 10.1 myself so I don't know |
|
@martinbonnin @fougere-mike what is the reason for dropped frames? @fougere-mike you have a tablet, right? Any ideas? |
|
@hiteshgupta33 I have tested the stream you provided (http://vod.hdi.cdn.ril.com/vod/_definst_/smil:hdivod/4/284/0_y74kwawj.smil/playlist.m3u8) on my samsung tablet (SM-P600). It did not appear corrupt, and did not appear distorted. Until I can reproduce the issue, I'm not really able to help. |
|
@fougere-mike can you try it on Nexus 7 (Tablet) with my test stream url. It happens on that also. Thanks buddy |
|
@hiteshgupta33 I just tried it on the nexus 7. I do not see any problems. |
|
@fougere-mike can you send me your demo code where you tried this, i want to see if i am doing something wrong here. It's getting distorted on every tablet i can think of except on SM-P600(a little happens on this too). |
|
I was testing your stream by passing the URL to our player; unfortunately I cannot give you that code. However, one thing to check is that you are correctly handling the onVideoSizeChanged(int, int) event -- this is fired whenever the player detects a change in the dimensions of the video. Depending on how your app is structured, you may need to use onVideoSizeChanged() to resize your surface view. |
@martinbonnin
Hi
After this fix, at least my videos started playing but the video is whole distorted from the bottom as if the video is corrupted.
The same video plays fine with the native Media player.
Here are some of the details for the same:
Device : Samsung 10.1 (SM-P601)
API Level: 4.4.2
We are using MAIN PROFILE with 200k to 800k bit rate.
But this is happening with all the devices, checked with Asus 7 as well.
The text was updated successfully, but these errors were encountered: