Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and utilise native IP address representations. #17

Open
amcgregor opened this issue Mar 24, 2021 · 3 comments
Open

Support and utilise native IP address representations. #17

amcgregor opened this issue Mar 24, 2021 · 3 comments

Comments

@amcgregor
Copy link
Member

https://docs.python.org/3/library/ipaddress.html

@mentalisttraceur
Copy link

This would pair well with exposing the host part as either an FQDN object or an IP address object, for any URI scheme where the host can be unambiguously interpreted as one of those two.

@mentalisttraceur
Copy link

I'm actually here because I was going to open an issue suggesting a bigger breaking-change improvement, and my suggestion was going to include this (parsing the host part as either an FQDN or IP for the URI schemes that it makes sense for, and then presenting it as those objects).

@mentalisttraceur
Copy link

Of course sometimes host parts aren't either an IP address nor an "FQDN" per se (like, is localhost an FQDN? I wouldn't normally think to classify it as one).

So maybe the right name for such an object isn't "FQDN". Or maybe it's appropriate to categorize the host into three or more types of thing - FQDN, IP address, and something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants