-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library is breaking safari-features (e.g. web-push) #22
Comments
I opened the test/demo files on my Mac, and on Mac every browser I have fully worked, except Safari won't show any images, it did show the shaded containers with the info and that was it.... |
UPDATE! With Safari on Mac OS, if you do not have the Developer option turned on you will not see the demo live or function.. With my test the server version was fully functional before turning the Developer mode on, once it was activated then the local demo files were also working. On my Mac I opened the local files with VS Code and then used LiveServer to view the content in Safari to see if the issue was still there and it was not; this prompted me to do an actually test from a live website and it worked.. |
This issue is not about the functionality of the library, it's working fine as it is. |
In this line the variable
safari
is set, which will also overridewindow.safari
:universal-parallax/dist/universal-parallax.js
Line 13 in 257276d
However, this is already set by safari itself and contains important objects like
window.safari.pushNotification
.This prevents/breaks web-push functionality on safari.
These checks should be scoped locally anyways to prevent polluting the global namespace.
The text was updated successfully, but these errors were encountered: