You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If no other class than .parallax is specified, adding this CSS it's kinda unnecessary code because the .parallax class already have it, no?
Also, this piece of code takes away the possibility of having repeated backgrounds with other size than cover and with a custom position (different then center). For instance, it's useful when you have small size GIFs or patterns and you need to repeat the background to fill the parallax:
Hi!
Since in your
.css
you told us to add this:universal-parallax/dist/universal-parallax.css
Lines 11 to 16 in 257276d
Why then you have an if on your
.js
doing the same thing?universal-parallax/dist/universal-parallax.js
Lines 114 to 118 in 257276d
If no other class than
.parallax
is specified, adding this CSS it's kinda unnecessary code because the.parallax
class already have it, no?Also, this piece of code takes away the possibility of having repeated backgrounds with other size than cover and with a custom position (different then center). For instance, it's useful when you have small size GIFs or patterns and you need to repeat the background to fill the parallax:
Background image:
https://i.imgur.com/o4hJvT7.gif
Code:
Parallax before removing the if (if's code replacing the inline style I put on div):
Parallax after removing the if (same code it works now):
(The parallax effect was working on both, trust me)
The text was updated successfully, but these errors were encountered: