Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useCanAccessResources cannot have react-query options #10362

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Fix useCanAccessResources cannot have react-query options #10362

merged 4 commits into from
Nov 20, 2024

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Nov 20, 2024 •
edited by fzaninotto
Loading

Problem

useCanAccessResources currently uses useQueries. As such, it doesn't accept useQuery options like enabled.

Solution

Refactor it to use useQuery instead.

How To Test

  • All tests should pass without modification

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
    - [ ] The PR includes unit tests (if not possible, describe why)
    - [ ] The PR includes one or several stories (if not possible, describe why)
    - [ ] The documentation is up to date

Also, please make sure to read the contributing guidelines.

@fzaninotto fzaninotto added the RFR Ready For Review label Nov 20, 2024
@fzaninotto fzaninotto merged commit b6b10e5 into master Nov 20, 2024
15 checks passed
@fzaninotto fzaninotto deleted the fix-can-access-resources branch November 20, 2024 10:54
@fzaninotto fzaninotto added this to the 5.3.5 milestone Nov 20, 2024
@djhi djhi modified the milestones: 5.3.5, 5.4.0 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto