Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR Checksum #62

Closed
meo-pill opened this issue Jan 12, 2025 · 3 comments
Closed

ERROR Checksum #62

meo-pill opened this issue Jan 12, 2025 · 3 comments

Comments

@meo-pill
Copy link
Contributor

meo-pill commented Jan 12, 2025

copy_checksum="${copy_checksum} $(cksum "${file_path}")"

The calculation of the checksum is not donne on the new file but on the original file
copy_checksum="${copy_checksum} $(cksum "${tmp_file_path}")"
@adiov
@markusressel

@meo-pill
Copy link
Contributor Author

we need to find a way to corrupt a copy during before the checksup prosses to be sure that this is a one time error

@adiov
Copy link
Contributor

adiov commented Jan 12, 2025

Oof, that's not good. Fortunately, #61 should fix this by moving over to cmp, which also comes with performance gain.

@meo-pill
Copy link
Contributor Author

Now that it have been merged, I mark it a resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants