Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applefy ASDI #6

Open
lwelzel opened this issue Oct 17, 2023 · 2 comments
Open

Applefy ASDI #6

lwelzel opened this issue Oct 17, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@lwelzel
Copy link

lwelzel commented Oct 17, 2023

Hi Markus,

I would like to use applefy to characterize the performance of a HCI data reduction algorithm. While I understand that applefy currently only supports ADI cubes out of the box, I would like to know if there is a way to extend this package to also handle full ASDI cubes (and 3D PSF template) to determine contrast curves and/or grids for a data reduction algorithm. Any advice on similar packages that support ASDI cubes would also be appreciated.

Thanks for the great package!

@markusbonse
Copy link
Owner

Hi Lukas,

at the moment there is no support for ASDI data in applefy. However, it should be possible to extend the current code without rewriting the whole package. If you have the time to implement these features it would be great! Feel free to create a pull request and I'll review your changes.

In order to extend applefy for ASDI data you need to extend / modify the Contrast class. It is the main capsule for all fake planet experiments and data handling. To do so inherit from it and change the functions needed to insert the fake planets.

Those probably include:

  • design_fake_planet_experiments
  • _run_fake_planet_experiment
  • prepare_contrast_results
  • compute_analytic_contrast_curves
  • compute_contrast_grids

The statistical tests as well as the post-processing algorithms are separate from the calculation of the contrast grids and contrast curves. If you manage to implement your changes within the current package structure you should be able to use these features without further modifications.
I hope this helps!

Markus

@markusbonse markusbonse added the enhancement New feature or request label Oct 31, 2023
@lwelzel
Copy link
Author

lwelzel commented Nov 3, 2023

Hi Markus,

Thank you for your advice on the required changes to support ASDI data, I will get back to you if I have a working implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants