Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Line Numbers are Incorrect #6

Open
marksalpeter opened this issue Nov 29, 2015 · 1 comment
Open

Log Line Numbers are Incorrect #6

marksalpeter opened this issue Nov 29, 2015 · 1 comment
Assignees
@marksalpeter
Labels
bug
Milestone
v1.0

Comments

@marksalpeter
Copy link
Owner

use the runtime package to determine the correct part of the callstack to pull the line number from before adding it to logger.lines
@marksalpeter marksalpeter added this to the v1.0 milestone Nov 29, 2015
@marksalpeter marksalpeter self-assigned this Nov 29, 2015
marksalpeter added a commit that referenced this issue Nov 29, 2015
@marksalpeter
wokred on #6, fixed the loggers line number for the majority of situa…
f57cd22 
…tions
marksalpeter added a commit that referenced this issue Nov 29, 2015
@marksalpeter
more work on #6
4cd1f68
@marksalpeter
Copy link
Owner Author

this is currently fixed for the majority of use cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marksalpeter marksalpeter

Labels
bug
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@marksalpeter