Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

Critical dependency: the request of a dependency is an expression #27

Open
MiloCasagrande opened this issue Feb 26, 2019 · 4 comments
Open

Comments

@MiloCasagrande
Copy link

MiloCasagrande commented Feb 26, 2019

After upgrading from 1.3.3 to 1.5.0, using marko-loader with webpack, I get the following error:

Critical dependency: the request of a dependency is an expression

I can reproduce the same issue using the marko-webpack repository after upgrading all dependencies in there.

This is the output taken from the marko-webpack repository when running npm start:

WARNING in ./src/components/app-tabs/index.marko 1:0-18
Critical dependency: the request of a dependency is an expression
 @ ./src/components/app/index.marko
 @ ./src/pages/home/client.js

When loading the app from a brwoser, the app itself is "broken": no CSS and no interactivity. This is the error I get from the browser console:

Uncaught Error: Cannot find module 'undefined'

Dependencies:

  • marko 4.15.2
  • marko-loader 1.5.0
  • webpack 4.25.9
  • webpack-cli 3.2.3
@sqrter
Copy link

sqrter commented Mar 12, 2019

+1

1 similar comment
@jesse1983
Copy link

+1

@eltimn
Copy link

eltimn commented Apr 26, 2019

We're seeing this problem as well. We narrowed it down to the 1.4.0 release.

@arthurchenn
Copy link

Same problem here, last working version is 1.3.3.
Will it ever be fixed?

Dependencies:

marko 4.18.25
marko-loader 1.5.0
webpack 4.41.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants