Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Able to update the Entity Block even it is used in current graph #290

Open
Chunyu01 opened this issue Oct 1, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@Chunyu01
Copy link

Chunyu01 commented Oct 1, 2020

Is your feature request related to a problem? Please describe.
Pipes does not allow to add or delete the properties on the entity block if it is used in current graph.
It will take lots of extra work to remove the current used entity block, then add the updated entity block. All the mapping will be lost.
We are the customer of MarkLogic and heavily using Pipes.
Often we need to update the entity definitions later on and it is very difficult to do it in Pipes because of the above reason.
Describe the solution you'd like
It will be good to be able the update the entity block even it is used in the current graph.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Chunyu01 Chunyu01 changed the title [FEATURE]Able to edit the Entity Block even it is used in current graph [FEATURE]Able to update the Entity Block even it is used in current graph Oct 1, 2020
@sashamitrovich sashamitrovich added the enhancement New feature or request label Oct 1, 2020
@sashamitrovich
Copy link
Contributor

sashamitrovich commented Oct 1, 2020

Thanks for this ticket, @Chunyu01

Some observations:

  • If the properties in the entity definition are renamed, there's no way to "capture" this fact and preserve the mapping so the mapping to renamed properties would be lost in the Pipes graph
  • It would be possible to handle the case of adding / removing properties
  • The question is at which moment should Pipes detect the change. It would be possible to do this check on graph load and ask the user if they want to update the entities at that moment.

@Chunyu01
Copy link
Author

Chunyu01 commented Oct 1, 2020

Thanks for this ticket, @Chunyu01

Some observations:

  • If the properties in the entity definition are renamed, there's no way to "capture" this fact and preserve the mapping so the mapping to renamed properties would be lost in the Pipes graph
  • It would be possible to handle the case of adding / removing properties
  • The question is at which moment should Pipes detect the change. It would be possible to do this check on graph load and ask the user if they want to update the entities at that moment.

Thanks @sashamitrovich

It will be fine with above point 1 and 2.
Point 3, we are not fussy about the method, but just would like to have a way to be able to update the current entity block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants