Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Exceptions in the GetResponseAsync() Method #16

Open
markjamesm opened this issue Jan 1, 2022 · 1 comment
Open

Handle Exceptions in the GetResponseAsync() Method #16

markjamesm opened this issue Jan 1, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
1.0.0

Comments

@markjamesm
Copy link
Owner

Need to handle exceptions encountered in GetResponseAsync() by adding context and throwing them back to the caller. Returning errors for malformed responses would mean that we could stop using null coalescing in most places within the library.
@markjamesm markjamesm added enhancement New feature or request help wanted Extra attention is needed labels Jan 1, 2022
@markjamesm markjamesm added this to the 1.0.0 milestone Jan 1, 2022
@markjamesm markjamesm mentioned this issue Jan 1, 2022
Open
@bkowalczyk88
Copy link
Contributor

bkowalczyk88 commented Mar 12, 2022 •
edited
Loading

Not sure what do you mean by "adding context and throwing them back to the caller"?
Can you provide some examples? So I could understand and I'd like to try to look at it.
(I admit - I make a fork of this project and looking at it. honestlyI want to do total reorganization but not sure if you would like it :D ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@bkowalczyk88 @markjamesm