Avoid "and 4 weeks", or "and 12 months"

[captn3m0]

It is possible to get results that use "and 4 weeks", or "and 12 months". It would be better to round such usage up.

Jekyll::Timeago.timeago(Date.new(2024,8,15))
=> "in 1 month and 4 weeks"
Jekyll::Timeago.timeago(Date.new(2026,06,15))
=> "in 1 year and 12 months"

[markets]

Hello @captn3m0 👋🏼

Maybe by using the "threshold" setting #24?

[captn3m0]

Yeah, I was thinking of adapting threshold as well for rounding up (current implementation only rounds down). I'll see if I can work on a PR.

[captn3m0]

Also, this felt like a bug more than a feature request - "1 year and 12 months" should always be rounded up to 2 years, irrespective of a threshold.

[markets]

Also, this felt like a bug more than a feature request - "1 year and 12 months" should always be rounded up to 2 years, irrespective of a threshold.

Yes, I kind of agree with that. Is that also happening with no custom threshold at all 🤔?

For reference, all this logic is implemented in this method:

jekyll-timeago/lib/jekyll-timeago/core.rb

Lines 69 to 85 in f12f833

	def build_time_ago_slots(days_passed, depth, threshold, current_slots = [])
	return current_slots if depth == 0 || days_passed == 0
	range = days_to_range(days_passed)
	days = days_in(range)
	num_elems = (days_passed / days).to_i
	current_slots << t(range, count: num_elems)
	pending_days = days_passed - (num_elems * days)
	if pending_days >= (days_passed * threshold).floor
	build_time_ago_slots(pending_days, depth - 1, threshold, current_slots)
	else
	current_slots
	end
	end

[captn3m0]

I did try with zero threshold, but just noticed I ran my tests in a repo with _config.yml that has a threshold set.

I'll double check in a clean environment and report back.