This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Modal background stay after close #237

Open

elchiconube opened this issue Nov 22, 2022 · 1 comment · May be fixed by #239

Assignees

elchiconube commented Nov 22, 2022

When I call <Modal /> component and pass the prop open with false the background block de UI. You need to click to remove it

The text was updated successfully, but these errors were encountered:

Author

elchiconube commented Nov 22, 2022

I cannot create a Pull request so here's the fix proposal. Just change the JSX template adding <dialog /> tag inside open conditional rendering

  return (
    open && (
      <dialog className={cx('ola_modal', variant && `is-${variant}`, { 'is-closable': closable }, className)} {...props} ref={modal} onClick={clickOutside}>
      ...
      </dialog>
    )
  )

oscarotero assigned pedroparra

elchiconube linked a pull request

that will close this issue

fix: close modal dialog #239

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.