Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Angular 6.0 #156

Open
yoginm opened this issue May 17, 2018 · 4 comments
Open

Incompatible with Angular 6.0 #156

yoginm opened this issue May 17, 2018 · 4 comments

Comments

@yoginm
Copy link

yoginm commented May 17, 2018

Get following error after upgrade to Angular 6.0

node_modules/angular2-toaster/src/toaster.service.d.ts(3,10): error TS2305: Module '"Seller/node_modules/rxjs/Observable"' has no exported member 'Observable'.
node_modules/angular2-toaster/src/toaster.service.d.ts(5,10): error TS2305: Module '"Seller/node_modules/rxjs/Subject"' has no exported member 'Subject'.

@chrisbmoore
Copy link

It has to do with the Rxjs 6 changes. Considering the project hasn't even been updated to support Angular 4, I doubt Angular 6 support will get added soon.

Workaround fix could be to install rxjs-compat package:

npm install --save rxjs-compat

@yoginm
Copy link
Author

yoginm commented May 17, 2018

Yes, I see that we can work temporarily with rxjs-compat. I just want to see if this will be updated. rxjs-compat adds overhead to my application. At some point it will need to be taken out. Hoping this would be updated to rxjs 6..

@PavolSvidran
Copy link

Hi, if it is possible to upgrade it, it's a simple change, if you want help, I will help you.
RxJs-compat is redundant package I want to get rid of as soon as it goes, as @yoginm note it overhead application and after RxJs7 it will not work anymore.

@PascalHonegger
Copy link

I created a fork (of a fork...) which has the minimal changes required for angular 6 to run (https://github.com/PascalHonegger/ng-datatable - https://www.npmjs.com/package/@pascalhonegger/ng-datatable). We use this version for our project and were able to get rid of the rxjs-compat package. I'm also happy to keep it updated / merged wherever an active version of this package lives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants