Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

had problems with the mqtt-wrapper... #7

Open
mucFlorianH opened this issue Aug 20, 2022 · 3 comments
Open

had problems with the mqtt-wrapper... #7

mucFlorianH opened this issue Aug 20, 2022 · 3 comments

Comments

@mucFlorianH
Copy link

Hi Marius,

I used your code to connect my Debit to my home automation system. Unfortunately I had some problems and I think there are two errors in your code.

On line 15:
this.continent = ecovacsDeebot.countries['DE'].continent.toLowerCase();
should be:
this.continent = ecovacsDeebot.countries[country.toUpperCase()].continent.toLowerCase();

On line 17:
this.deviceId = EcoVacsAPI.md5(machineId.machineIdSync());
should be:
this.deviceId = EcoVacsAPI.getDeviceId(machineId.machineIdSync());

And in isDeviceReady() the connect() is missing -> I added in line 61: vacuum.connect();

Kind regards, Florian

@pseudex
Copy link

pseudex commented Sep 17, 2022

be careful with these changes. for this you have to update the ecovacs-deebot from npm to the latest (0.8.3)

@mucFlorianH
Copy link
Author

I just had a look and obviously did this... Why do you think, that I have to be careful? Did it work with previous versions of ecovacs-deebot without the 'vacuum.connect()'?

@pseudex
Copy link

pseudex commented Sep 17, 2022

my robot did not work with the current version on github. with your changes I got mine to work. but your changes are not compatible with 0.4 of ecovacs-deebot. there are runtime errors. when I have time I will make a pull request.

there is also a mistake in the handleCommands function. If you have multiple robots the commands is executed on every device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants