Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from AbstractDifferentiation to DifferentiationInterface? #19

Open
gdalle opened this issue Jul 29, 2024 · 4 comments · May be fixed by #20
Open

Switch from AbstractDifferentiation to DifferentiationInterface? #19

gdalle opened this issue Jul 29, 2024 · 4 comments · May be fixed by #20

Comments

@gdalle
Copy link

gdalle commented Jul 29, 2024

Hi there @marius311! My new package DifferentiationInterface is becoming the new standard for autodiff bindings, would you be open to a PR that transitions towards it?

@marius311
Copy link
Owner

Yep very open. I would just remove AbstractDifferentiation entirely and bump the major-number version.

@dominic-chang
Copy link

dominic-chang commented Feb 18, 2025

Replace AbstractDifferentiation with DifferentiationInterface #20

This seems great! Is this branch ready for use? The tests failed for me so I thought I would ask. I get a compatibility issue:

ERROR: Unsatisfiable requirements detected for package FillArrays [1a297f60]:
 FillArrays [1a297f60] log:
 ├─possible versions are: 0.2.0-1.13.0 or uninstalled
 ├─restricted by compatibility requirements with Soss [8ce77f84] to versions: 0.11.0-0.13.11
 │ └─Soss [8ce77f84] log:
 │   ├─possible versions are: 0.1.0-0.21.2 or uninstalled
 │   └─restricted to versions 0.21.2-0.21 by project [26513d63], leaving only versions: 0.21.2
 │     └─project [26513d63] log:
 │       ├─possible versions are: 0.0.0 or uninstalled
 │       └─project [26513d63] is fixed to version 0.0.0
 └─restricted by compatibility requirements with DifferentiationInterface [a0c0ee7d] to versions: 1.7.0-1.13.0 — no versions left
   └─DifferentiationInterface [a0c0ee7d] log:
     ├─possible versions are: 0.1.0-0.6.42 or uninstalled
     └─restricted to versions 0.5 by MuseInference [43b88160], leaving only versions: 0.5.0-0.5.17
       └─MuseInference [43b88160] log:
         ├─possible versions are: 0.3.0 or uninstalled
         └─MuseInference [43b88160] is fixed to version 0.3.0

@gdalle
Copy link
Author

gdalle commented Feb 19, 2025

I just updated that branch to the latest version of DI but I think other compat bounds need to be loosened for tests, most notably that on Turing in test/Project.toml

@marius311
Copy link
Owner

Great, thanks for that, gonna try to take a look today and hopefully merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants