Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Turing 0.28 #15

Merged
merged 1 commit into from
Aug 27, 2023
Merged

upgrade to Turing 0.28 #15

merged 1 commit into from
Aug 27, 2023

Conversation

marius311
Copy link
Owner

No description provided.

@marius311
Copy link
Owner Author

Hey @thorek1, sorry this is taking a bit. Imo the reason it doesn't work with threads is a problem in DynamicPPL, but as a workaround if you define this, this branch + threads + latest Turing should work:

import Turing.DynamicPPL as DynPPL
function DynPPL.ThreadSafeVarInfo(vi::DynPPL.SimpleVarInfo)
    return DynPPL.ThreadSafeVarInfo(vi, Vector{Real}(zeros(typeof(DynPPL.getlogp(vi)), Threads.nthreads())))
end

Going to explore what type of fix or workaround is possible to commit but in the meantime I think that gets you something working.

@marius311 marius311 merged commit cb6def9 into main Aug 27, 2023
3 checks passed
@marius311
Copy link
Owner Author

@thorek1 merged and tagged a new version (0.2.3), I'm going to file an issue in DynamicPPL until then I recommend just use that hot-fix locally and don't hestitate to let me know if you run into any other issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant