Add TT implementation. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to add TT to Search. However search currently is just a simple function, so I would need to add it as a parameter. Weird. I have to think if I should do it correctly now or temporarily do it like that. |
|
TT should be either a global variable or we can wrap search into some class and put TT as a field there. |
|
Yes, we should. There should be a class that implements Engine like MinMaxEngine or sth. |
|
Oh that's what the engine class is for. I can refactor code to fit this template then. |
|
I have just committed changes we were discussing to #25. Feel free to review them. |
|
Ok done. |
Implementation based on https://www.chessprogramming.org/Shared_Hash_Table\#Lockless. TTData stores score, move, depth, age and type.
std::vector requires elements to be copy-constructible, which std::atomic doesn't allow. I guess we won't be resizing the TT after the creation, so simple dynamic array should be enough for now.
Gustav2137
reviewed
Jun 5, 2024
|
lgtm, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.