Function call CSE pass #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if you could take a look @mscuttari and see what you think. As you asked it does not currently handle equations with induction variables. Additionally I was unsure whether calls in the initial equations had to be handled differently, so for not they are ignored. There is also just one test. I read the page on filecheck tests for mlir, and they mention that one should try to make the tests as isolated as possible. I tried to do that for the one I have made, so please let me know if something can be improved about that. I'll add some more before finishing the PR. |
mscuttari
requested changes
Oct 13, 2024
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
5 times, most recently
from
1990b4d to
a7398f8
Compare
mscuttari
requested changes
Oct 21, 2024
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
from
aa3c4b2 to
f9d8329
Compare
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
from
5a8761a to
1237c42
Compare
mscuttari
requested changes
Oct 25, 2024
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
from
965fb28 to
da0eba0
Compare
mscuttari
requested changes
Oct 27, 2024
lib/Dialect/BaseModelica/Transforms/EquationExpressionOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
lib/Dialect/BaseModelica/Transforms/EquationExpressionOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
lib/Dialect/BaseModelica/Transforms/EquationExpressionOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
lib/Dialect/BaseModelica/Transforms/EquationExpressionOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
lib/Dialect/BaseModelica/Transforms/EquationExpressionOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
5 times, most recently
from
d7b4c41 to
90fb249
Compare
mscuttari
requested changes
Oct 28, 2024
lib/Dialect/BaseModelica/Transforms/EquationExpressionOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
from
90fb249 to
d6211a3
Compare
mscuttari
requested changes
Oct 31, 2024
lib/Dialect/BaseModelica/Transforms/EquationExpressionOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
from
d6211a3 to
f628f89
Compare
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
from
f628f89 to
5aebc97
Compare
mscuttari
requested changes
Oct 31, 2024
lib/Dialect/BaseModelica/Transforms/EquationExpressionOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
lib/Dialect/BaseModelica/Transforms/EquationExpressionOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
from
5aebc97 to
407ecd0
Compare
|
/fast-forward |
arrangabriel
force-pushed
the
arrangabriel/function-cse
branch
from
407ecd0 to
6f004f5
Compare
|
I made a few more changes, but nothing important |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pass that hoists repeated function calls with equivalent arguments in and between equations into new equations, so they are only computed once.