Add snapshot frequency to Euler Forward driver #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaugdahl
force-pushed
the
thaugdahl/snapshot-frequency
branch
from
745e804
to
76159f6
Compare
Add snapshot frequency for euler forward and printer disable flag for CSV printer
thaugdahl
force-pushed
the
thaugdahl/snapshot-frequency
branch
from
b159d10
to
e99ac65
Compare
|
@mscuttari Added a disable printing flag to the CSV printer as well. |
mscuttari
requested changes
Oct 14, 2024
| } while (std::abs(simulation::getOptions().endTime - time) >= | ||
| eulerforward::getOptions().timeStep); | ||
| updateNonStateVariables(); | ||
| EULER_FORWARD_PROFILER_NONSTATEVAR_STOP; | ||
|
|
||
| if (marco::runtime::simulation::getOptions().debug) { |
There was a problem hiding this comment.
This should be done only if the snapshot steps condition holds.
There was a problem hiding this comment.
The macros / assertions -- introduced as sequence points?
lib/Simulation/Runtime.cpp
Outdated
| @@ -270,6 +270,7 @@ namespace | |||
| dynamicModelEnd(); | |||
| SIMULATION_PROFILER_DYNAMIC_MODEL_STOP; | |||
|
|
|||
|
|
|||
| @@ -34,6 +34,7 @@ namespace marco::runtime | |||
|
|
|||
| std::vector<int64_t> derOrders; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Is this whiteline inserted by clang-format? :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a snapshot frequency CLI parameter for the formatter.
Setting a positive value greater than 1 will cause the printer to skip iteration numbers that are not divisible by the snapshot frequency.