Bug 1841545 [wpt PR 40861] - Account that send_keys throws different exceptions in inert test, a=testonly

marco-c · marco-c · commit 8dacfaee96f3 · 2023-07-16T01:33:18.000Z
Automatic update from web-platform-tests
Account that send_keys throws different exceptions in inert test (#40861)

#40774 made it so send_keys no longer throws in non-interactive nodes, however it still throws for a different reason. Use test_driver actions and stop checking that an exception is thrown. The value assert below is enough to check that the field is not editable.
--

wpt-commits: 9150c19f5e6af10b1487d177779cceaf30f33d96
wpt-pr: 40861

UltraBlame original commit: 639ba1e0792736f8f9f79e2a835f0577dabd8186
diff --git a/testing/web-platform/tests/inert/inert-node-is-uneditable.html b/testing/web-platform/tests/inert/inert-node-is-uneditable.html
@@ -7,6 +7,7 @@
     <script src="/resources/testharness.js"></script>
     <script src="/resources/testharnessreport.js"></script>
     <script src="/resources/testdriver.js"></script>
+    <script src="/resources/testdriver-actions.js"></script>
     <script src="/resources/testdriver-vendor.js"></script>
   </head>
 <body>
@@ -16,23 +17,26 @@
 var notEditable = document.querySelector('#not-editable');
 var editable = document.querySelector('#editable');
 
+function sendKey(key) {
+    return new test_driver.Actions()
+        .keyDown(key)
+        .keyUp(key)
+        .send();
+}
+
 promise_test(async function() {
     notEditable.focus();
     var oldValue = notEditable.textContent;
     assert_equals(oldValue, "I'm not editable.");
-    await promise_rejects_js(
-        this,
-        Error,
-        test_driver.send_keys(notEditable, 'a'),
-        "send_keys should reject for non-interactive elements");
+    await sendKey('a');
     assert_equals(notEditable.textContent, oldValue);
 }, "Can't edit inert contenteditable");
 
 promise_test(async () => {
     editable.focus();
     var oldValue = editable.textContent;
     assert_equals(oldValue, "I'm editable.");
-    await test_driver.send_keys(editable, 'a');
+    await sendKey('a');
     assert_not_equals(editable.textContent, oldValue);
 }, "Can edit non-inert contenteditable");
 
