Merge pull request #83 from marceloexc/feat/confirm-quit

add a "Warn before Quitting" toggle

Author: marceloexc

rm2000/AppKitWindowManagerDelegate.swift

@@ -10,18 +10,19 @@ class WindowController: NSWindowController {
   }
 }
 
-class AppKitWindowManagerDelegate: NSObject, NSApplicationDelegate,
-  NSWindowDelegate
-{
-
-  @Published var willTerminate = false
+class AppKitWindowManagerDelegate: NSObject, NSApplicationDelegate, NSWindowDelegate {
+  
   var mainWindowController: WindowController?
   let recordingState = TapeRecorderState.shared
   let storeKitManager = StoreManager.shared
   let mainWindowIdentifier = NSUserInterfaceItemIdentifier("mainWindow")
 
   private var onboardingWindowController: NSWindowController?
   private var hudHostingView: NSHostingView<AnyView>?
+  @MainActor private var confirmOnQuit: Bool {
+    AppState.shared.confirmOnQuit
+  }
+  @Published private var willTerminate = false
 
   private var hudWindow: NSWindow?
   private var mainWindow: NSWindow?
@@ -145,6 +146,42 @@ class AppKitWindowManagerDelegate: NSObject, NSApplicationDelegate,
     onboardingWindowController?.showWindow(nil)
     window.center()
   }
+  
+  func applicationShouldTerminate(_ sender: NSApplication) -> NSApplication.TerminateReply {
+    if confirmOnQuit {
+      self.willTerminate = true
+      self.promptQuitConfirmation()
+      return .terminateLater
+    }
+    return .terminateNow
+  }
+  
+  /// dont close (user canceled)
+  func `continue`() {
+    NSApplication.shared.reply(toApplicationShouldTerminate: false)
+  }
+  /// close
+  func close() {
+    NSApplication.shared.reply(toApplicationShouldTerminate: true)
+  }
+  
+  func promptQuitConfirmation() {
+    let alert = NSAlert()
+    alert.messageText = "Really Quit?"
+    alert.informativeText = "You will not be able to use your Global Recording Hotkey to record."
+    alert.alertStyle = .critical
+    alert.addButton(withTitle: "Yes")
+    alert.addButton(withTitle: "No")
+    
+    DispatchQueue.main.async {
+      let response = alert.runModal()
+      if response == .alertFirstButtonReturn {
+        self.close()
+      } else {
+        self.continue()
+      }
+    }
+  }
 
   /*
 	 A function like this should never exist.

rm2000/AppState.swift

@@ -28,6 +28,8 @@ import SwiftUI
     }
   }
 
+  @AppStorage("confirm_on_quit") var confirmOnQuit: Bool = false
+  
   @AppStorage("sample_directory") var sampleDirectoryPath: String = ""
   @AppStorage("sample_directory_bookmark") private var sampleDirectoryBookmark:
     Data?

rm2000/Views/Settings/GeneralTabView.swift

@@ -6,7 +6,8 @@ import SwiftUI
 struct GeneralTabView: View {
   @Environment(\.openURL) private var openURL
   @State private var isDockHidden: Bool = AppState.shared.hideDockIcon
-
+  @State private var isConfirmOnQuit: Bool = AppState.shared.hideDockIcon
+  
   var body: some View {
     VStack {
       GroupBox {
@@ -23,6 +24,16 @@ struct GeneralTabView: View {
                 AppState.shared.hideDockIcon = newValue
               }
           } footer: {
+              //
+          }
+          
+          Section {
+            Toggle(isOn: $isConfirmOnQuit) {
+              Text("Warn Before Quitting (⌘Q)")
+            }.toggleStyle(.switch)
+              .onChange(of: isConfirmOnQuit) { _, newValue in
+                AppState.shared.confirmOnQuit = newValue
+              }
           }
 
           KeyboardShortcuts.Recorder(