Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project nav-marker-rules will typically not be used on activation #20

Open
johnarwe opened this issue Jul 26, 2017 · 1 comment
Open

Comments

@johnarwe
Copy link

Once the initial display issue described by #19 is fixed, another problem will become apparent: currently nav-view and nav-parser each refer to the other, but nav-parser may be incompletely initialized at the point when nav-view would build the panel (even if nav-view doing so for an already-open file was triggered using a atom.workspace.observeTextEditors event... I've tested it). Nav-parser's constructor calls getProjectRules, but that requires I/O when project-level rules file(s) are present; the I/O will always be asynch, and may (in the general, and already tested, cases) finish after events like observeTextEditors have fired. In order to truly fix the race, any existing panels must be removed (and the active one rebuilt) when the I/Os complete.

I am building a pull request to split nav-parser's initialization (for clarity mostly), and to destroy/rebuild all the panels whenever a project rules file read operation completes. I've tested the flow and it does fix the problem, but separating the code for each of the problems into distinct pull requests will require a bit more time.

johnarwe added a commit to johnarwe/atom-nav-panel-plus that referenced this issue Jul 28, 2017
observeTextEditors resolves marcel0ll#19.
Redriving the parser when project rules exist (after the I/O to read the rules completes) resolves marcel0ll#20.
@johnarwe
Copy link
Author

johnarwe commented Aug 1, 2017

@0tho , I see you merged the pull request #23 into the development branch.

  1. What's the issue process, leave the issue open until it merges into master?
  2. Do you have any sense for when you expect to merge it into master?

Until it merges into master, I think no one using atom.io to get it will see the bug fixes in here and in #19 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant