Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove unnecessary border wrappers of Radio and Checkbox #936

Closed
marc2332 opened this issue Sep 28, 2024 · 0 comments · Fixed by #955
Closed

refactor: Remove unnecessary border wrappers of Radio and Checkbox #936

marc2332 opened this issue Sep 28, 2024 · 0 comments · Fixed by #955
Labels
good first issue Good for newcomers internal impovement👍 Internal code improvements
Milestone
0.3.0

Comments

@marc2332
Copy link
Owner

These 2 components currently have a rect wrapper that is only used to render a border for when the element is focused, this extra element is not really needed anymore as Freya now supports multiple borders as of #889
@marc2332 marc2332 added good first issue Good for newcomers internal impovement👍 Internal code improvements labels Sep 28, 2024
@marc2332 marc2332 added this to the 0.3.0 milestone Sep 28, 2024
@marc2332 marc2332 moved this to Todo in Freya Planning Sep 28, 2024
@ghost ghost mentioned this issue Oct 4, 2024
Merged
@marc2332 marc2332 moved this from Todo to Pending for Review in Freya Planning Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Pending for Review to Done in Freya Planning Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers internal impovement👍 Internal code improvements
Projects
Freya Planning
Status: Done
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

refactor: Remove unnecessary border wrappers of Radio and Checkbox vivi-rad/freya
1 participant
@marc2332