Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Migrate from manual method_channel to Pigeon #465

Open
T-moz opened this issue Jun 14, 2024 · 2 comments
Open

[FEATURE] Migrate from manual method_channel to Pigeon #465

T-moz opened this issue Jun 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@T-moz
Copy link

T-moz commented Jun 14, 2024

Feature Description

Currently, communication between dart and the native side is done by using method channel int the MapLibreMethodChannel class.
This works, but it's hard to maintain, it's not type safe, and the usage of jsonEncode in the main isolate causes performances issues.

Describe alternatives you've considered

Replacing the method channel with Pigeon.

Additional context

No response

@T-moz T-moz added the enhancement New feature or request label Jun 14, 2024
@kuhnroyal
Copy link
Collaborator

Are you willing to contribute a PR?

@josxha
Copy link
Collaborator

josxha commented Jun 23, 2024

Great suggestion @T-moz! I'd love to see a deacrese in code that is not type safe and Pigeon seems like a great choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants