Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a new GPMF (GoPro) parser #529

Merged
merged 7 commits into from
Aug 22, 2022
Merged

feat: add a new GPMF (GoPro) parser #529

merged 7 commits into from
Aug 22, 2022

Conversation

ptpt
Copy link
Member

@ptpt ptpt commented Aug 20, 2022 •
edited
Loading

  • The new GPMF parser is able to extract more useful information (e.g. GPS fix and GPS precision) for fixing the noisy GPS issues.
  • Also we use the video time clock to keep the video and its GPS track in sync, so users don't need this flag anymore --interpolation_use_gpx_start_time. This change also fixes Images sampled from GoPro split videos repeat the timestamps for each video segment #505
  • By default it removes GPS points with GPS fix == 0 or DoP precision > 1000 as they are considered as noisy. Users can configure these settings by these envvars: e.g. MAPILLARY_TOOLS_GOPRO_GPS_FIXES=0,2,3 MAPILLARY_TOOLS_GOPRO_MAX_GPS_PRECISION=100000
  • A test CLI is provided for extracting GPX from the GoPros python3 -m tests.cli.gpmf_parser /path/to/gopro.mp4. You can visualize the output in https://gpx.studio/

@ptpt ptpt changed the title feat: add a new gpmf (GoPro) parser feat: add a new GPMF (GoPro) parser Aug 22, 2022
@ptpt ptpt merged commit e433dbf into main Aug 22, 2022
@ptpt ptpt deleted the feat-new-gpmf-parser branch August 22, 2022 20:49
@ptpt ptpt mentioned this pull request Aug 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images sampled from GoPro split videos repeat the timestamps for each video segment
2 participants
@ptpt @facebook-github-bot