Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON format #108

Open
aleokdev opened this issue Dec 23, 2021 · 2 comments
Open

Support JSON format #108

aleokdev opened this issue Dec 23, 2021 · 2 comments
Labels
Milestone

Comments

@aleokdev
Copy link
Contributor

Support the Tiled JSON format as well, and add crate features for both XML and JSON loading, default to one of them, and mention it in docs/the README.

@bjorn
Copy link
Member

bjorn commented Dec 23, 2021

Regarding this I think we can learn a lot from https://gitlab.com/flukejones/tiled-json-rs. I think it has a pretty good data structure setup. Unfortunately it also appears unmaintained since two years.

@flukejones Would you still be available to help?

I think it would be great if we had a single well-maintained Tiled crate with support for both TMX and JSON (ideally as features, so people can avoid overhead of what they don't need).

@aleokdev aleokdev added this to the 1.0.0 milestone Dec 23, 2021
@flukejones
Copy link

It's not unmaintained per se, more like it's reached a point where I don't think there's anything to add (and it's still perfectly usable).

You're absolutely welcome to yeet any of the code I've written there in to this crate. If you do I'll add a little disclaimer directing people this way. Unfortunately I'm overworked so I'll maybe not be able to help.

I wouldn't worry too much about feature-gating, rust with LTO is very good at stripping out unused code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants