Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEG support in CLI #63

Open
thrnd opened this issue Jun 13, 2019 · 4 comments
Open

JPEG support in CLI #63

thrnd opened this issue Jun 13, 2019 · 4 comments

Comments

@thrnd
Copy link

thrnd commented Jun 13, 2019

For example, i have 2 exactly the same images but one in .png and other in .jpg extensions and i want to compare them.

@thrnd
Copy link
Author

thrnd commented Jun 13, 2019

Oh, right now i'm getting Error: Invalid file signature btw.

@thrnd thrnd changed the title Is it possible to compare images with different extension? Is it possible to compare images with different extensions? Jun 13, 2019
@mourner
Copy link
Member

mourner commented Jun 13, 2019

No — the CLI that accompanies the library is very basic and can only compare PNGs. We might want to add JPG support though, e.g. with https://github.com/eugeneware/jpeg-js

@mourner mourner changed the title Is it possible to compare images with different extensions? JPEG support in CLI Jun 13, 2019
@TacoTheDank
Copy link

TacoTheDank commented Apr 17, 2020

Please consider adding JPEG/JPG support 👍

@lukasoppermann
Copy link

I would also love it if you could add JPEG support. It could help with this issue: americanexpress/jest-image-snapshot#209 which is important as jest tests can be a lot faster when using jpeg instead of png.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants