Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent diff to be generated if threashold not reached #112

Open
bluepioupiou opened this issue Apr 25, 2022 · 2 comments
Open

Prevent diff to be generated if threashold not reached #112

bluepioupiou opened this issue Apr 25, 2022 · 2 comments
Labels

Comments

@bluepioupiou
Copy link

Hi,

I use pixelmatch to compare the whole bunch of screenshots i've been taking for each version of my product (approx 300 screenshots)
I use the binary to test each new screenshots against the previous one. But even if there is no differences (or if the diff threshold ins't reach), I still have a diff file generated which make the tester job quite difficult since he has to go through 300 files, even if there is no différence at all.

Can't you prevent the diff file to be writen if the threshold is not reached ?

@mourner
Copy link
Member

mourner commented Apr 25, 2022

Aren't you able to control this on your side? Run pixelmatch without diff, then run it again if there are differences above the threshold (which shouldn't happen often in tests, so performance isn't a concern)?

@bluepioupiou
Copy link
Author

bluepioupiou commented Apr 25, 2022

It could be a workaround indeed. But even with this, how can I tell the diff between the two doff files ?

AndI found it a bit heavy and would prefer if the tool don't generate a file to show that there is no diff...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants