Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database driver adaptations mysql #38

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

tksilicon
Copy link
Collaborator

I implemented MysqlClient based on the discussions of #32. Incorporated as much changes as I could. Take a look at it @manyuanrong. Other clients would be implemented if okay.

tksilicon and others added 23 commits August 4, 2020 14:29
feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL
@tksilicon tksilicon force-pushed the databaseDriverAdaptations-mysql branch from da918d5 to aa019fa Compare November 5, 2020 08:09
feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL

feat:databaseDriverAdaptations - MySQL
@tksilicon tksilicon force-pushed the databaseDriverAdaptations-mysql branch from aa019fa to 6e90cab Compare November 5, 2020 08:22
@tksilicon tksilicon self-assigned this Nov 5, 2020
@tksilicon tksilicon added the enhancement New feature or request label Nov 5, 2020
@tksilicon tksilicon linked an issue Nov 5, 2020 that may be closed by this pull request
6 tasks
@manyuanrong
Copy link
Owner

I made some modifications on this basis.
Mainly follow the following principles:

  • Different database drivers are placed under drivers and inherit DsoClient
  • For Dso users, you don't need to care about whether it is MysqlClient or other clients, and hide the details.

@manyuanrong
Copy link
Owner

And the dependency of mysql is placed in drivers/mysql.ts. Because in the future, driver/mysql will use dynamic import to avoid loading these dependencies when I use the postgres database.

@manyuanrong
Copy link
Owner

@tksilicon You can try to implement other drivers on this basis. Let's at least finish postgres

@tksilicon
Copy link
Collaborator Author

@tksilicon You can try to implement other drivers on this basis. Let's at least finish postgres

Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple database driver adaptations to do list
3 participants