Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedding by prepending “!” #1

Open
2 of 3 tasks
xplosionmind opened this issue May 8, 2021 · 7 comments
Open
2 of 3 tasks

Support embedding by prepending “!” #1

xplosionmind opened this issue May 8, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@xplosionmind
Copy link
Contributor

xplosionmind commented May 8, 2021

Suppose I am linking to a page with the following syntax: ![[file-to-embed]]. This should create a scrollable div of height no greater than the viewport which contains all of the embedded file or note.

Such implementation should be valid for:

  • other pages written in Markdown
  • images
  • PDFs
@manunamz manunamz added the enhancement New feature or request label May 11, 2021
@RoyiAvital
Copy link

I would go all the way and try to be compatible with Obsidian.

@xplosionmind
Copy link
Contributor Author

I would go all the way and try to be compatible with Obsidian.

What do you mean?

@RoyiAvital
Copy link

RoyiAvital commented May 18, 2021

Implement support for all these features (Its MarkDown syntax).

@manunamz
Copy link
Owner

manunamz commented May 18, 2021

I am definitely keeping an eye on them. I also want to be compatible with as many note-taking apps that support [[wikilinks]] as possible. If there are more standard specs I would like to adhere to them...But they are sparse.

If there are conflicts between app implementation (==highlight== syntax for example is ^^highlight^^ in Roam), I might add config flags...But we'll see what time allows for.

@RoyiAvital
Copy link

The most important feature is ![[]] for in place embedding.
I think the nice thing about it is that other parser just ignore it.

@manunamz
Copy link
Owner

manunamz commented Jun 25, 2021

Updated in v0.0.4.

✅ File-level wikilink embeds.
✅ Wikilink image embeds.

@manunamz
Copy link
Owner

PS If someone could let me know the status of PDF embeds that would be great. (I haven't tested it either way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants