Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Colorama init causes all ansi codes to be stripped when not in a tty #151

Open
li-wjohnson opened this issue Sep 8, 2020 · 2 comments

Comments

@li-wjohnson
Copy link

li-wjohnson commented Sep 8, 2020

Description

$ python -c "import halo; print('\033[93mfail\33[0m')"
prints "fail" in red
$ python -c "import halo; print('\033[31mfail\33[0m')" | cat
prints "fail" without color

This has many effects, including causing pytest --color=yes to stop working.

System settings

  • Halo version: 0.0.28

Expected behaviour

Importing halo should not affect terminal output. Halo should probably only import colorama on windows, and should not be calling colorama.init.

@lemassykoi
Copy link

lemassykoi commented Jan 21, 2021

Hi, same problem currently
All my ANSI colors are gone while using Halo 0.0.31

Edit : the fix #152 is actually working well

@adamyodinsky
Copy link

Same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants