Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect install location for package data #207

Open
manodeep opened this issue Dec 24, 2019 · 0 comments
Open

Incorrect install location for package data #207

manodeep opened this issue Dec 24, 2019 · 0 comments
Milestone

Comments

@manodeep
Copy link
Owner

General information

  • Corrfunc version: 2.3.2, (likely all versions affected)
  • platform: OSX (likely all supported OS'es)
  • installation method (pip/source/other?): pip

Issue description

The files needed for Corrfunc tests are located in theory/tests/ and mocks/tests/. Both these directories and the contained files need to be packaged in the source distribution to allow users to validate their install. However, these two directories are unexpectedly outside of the package root.

Expected behavior

Files should all be contained within package root directory.

Actual behaviour

The theory/ and mocks directory are created directly under site-packages.

What have you tried so far?

Modifying setup.py in all kinds of ways but nothing has succeeded so far.

Note The behaviour is different when installing with python setup.py install. The theory and mocks directories are then installed under site-packages/Corrfunc-<version>-py<ver>-macosx-<osx_ver>-x86_64.egg/.

Minimal failing example

Install Corrfunc with pip and then navigate to the relevant site-packages directory. There will be two directories -- theory/ and mocks/, that should not exist at that level. Uninstalling Corrfunc also leaves behind those two folders (all the contained files are deleted thankfully).

Installing with python setup.py install does not create this spill.

@manodeep manodeep added this to the v2.4.0 milestone Dec 24, 2019
@manodeep manodeep modified the milestones: v2.4.0, v2.5.0 Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant