Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual updating of source URL #565

Closed
thenetlogs opened this issue Apr 13, 2024 · 8 comments
Closed

Manual updating of source URL #565

thenetlogs opened this issue Apr 13, 2024 · 8 comments

Comments

@thenetlogs
Copy link

It seems that some sources are currently active again with the new URL, so some sort of option to edit the source URL would give users without coding knowledge an option to make source working and viable

@thenetlogs
Copy link
Author

ZinManga for example have a new working website, so a simple URL swap would make it work again I think

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Apr 13, 2024

An option is planned to let the user manually change the URL but only for website that often change url, as a per website setting. You know what i ma talking about, all those viet websites, sites like asura etc...

If users can change the url themselves for EVERY WEBSITES it would prevent us developers & users to know the website url changed . And that quite the problem in the long term.

If no one complain, we dont know about most websites. In the end we may end up having too many "fake dead" websites like that.
In fact, its already the case for Hakuneko. People just take websites for dead when they just changed url.

I am rather against this idea.

@MikeZeDev
Copy link
Contributor

There is also the question : "user has set a custom url, Update push a new url that works. What should we do? "

@thenetlogs
Copy link
Author

How would you decide which website is URL-changeable and which is not? What is a minimum URL change frequency to allow that option? Once a month? Once in 6 month? Would you need to put some argument in connector for allowing URL change?

How would not allowing users to change URL locally help with "dead" websites? My point is that if I know it's not dead and know new URL I can change it and continue to use it in Hakuneko

@thenetlogs
Copy link
Author

Update URL takes priority if it works

@Sheepux
Copy link
Contributor

Sheepux commented Apr 13, 2024

How would you decide which website is URL-changeable and which is not?

It's all about the amount of issues created that are about the same website. Usually when we get an issue every month on the same connector because trhey changed the domain again then we plan for custom URL change.
But i agree with MrLapin, for "not so changing" connectors, if people change on their side we wouldn't be aware of the incorrect
value.

How would not allowing users to change URL locally help with "dead" websites? My point is that if I know it's not dead and know new URL I can change it and continue to use it in Hakuneko

when it's just domain change it's usually fixed within the same day once reported (not currently as we're working on haru more than maintaining connectors)

@MikeZeDev
Copy link
Contributor

Moreover, i'd say perhaps for a rough 45% of the time an url change there is something else that changed and need to be fixed.

@MikeZeDev
Copy link
Contributor

Closed , as its a per website change, and decision is up to maintainers/devs

@MikeZeDev MikeZeDev closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants