Skip to content

Commit bd43ac8

Browse files
committed
Clarify library playback action labels (#17)
1 parent 00c4af9 commit bd43ac8

11 files changed

Lines changed: 35 additions & 14 deletions

File tree

src/PrompterOne.Shared/Localization/SharedResource.de.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,10 +1639,10 @@
16391639
<value>{0:N0} Wörter</value>
16401640
</data>
16411641
<data name="LibraryCardLearn" xml:space="preserve">
1642-
<value>Lernen</value>
1642+
<value>Üben</value>
16431643
</data>
16441644
<data name="LibraryCardRead" xml:space="preserve">
1645-
<value>Lesen</value>
1645+
<value>Teleprompter</value>
16461646
</data>
16471647
<data name="LibraryDefaultAuthor" xml:space="preserve">
16481648
<value>Du</value>

src/PrompterOne.Shared/Localization/SharedResource.es.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,10 +1639,10 @@
16391639
<value>palabras {0:N0}</value>
16401640
</data>
16411641
<data name="LibraryCardLearn" xml:space="preserve">
1642-
<value>Aprender</value>
1642+
<value>Practicar</value>
16431643
</data>
16441644
<data name="LibraryCardRead" xml:space="preserve">
1645-
<value>Leer</value>
1645+
<value>Teleprompter</value>
16461646
</data>
16471647
<data name="LibraryDefaultAuthor" xml:space="preserve">
16481648
<value>Tú</value>

src/PrompterOne.Shared/Localization/SharedResource.fr.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,10 +1639,10 @@
16391639
<value>Mots {0:N0}</value>
16401640
</data>
16411641
<data name="LibraryCardLearn" xml:space="preserve">
1642-
<value>Apprendre</value>
1642+
<value>S’entraîner</value>
16431643
</data>
16441644
<data name="LibraryCardRead" xml:space="preserve">
1645-
<value>Lire</value>
1645+
<value>Téléprompteur</value>
16461646
</data>
16471647
<data name="LibraryDefaultAuthor" xml:space="preserve">
16481648
<value>Vous</value>

src/PrompterOne.Shared/Localization/SharedResource.it.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,10 +1639,10 @@
16391639
<value>Parole {0:N0}</value>
16401640
</data>
16411641
<data name="LibraryCardLearn" xml:space="preserve">
1642-
<value>Imparare</value>
1642+
<value>Esercitati</value>
16431643
</data>
16441644
<data name="LibraryCardRead" xml:space="preserve">
1645-
<value>Leggere</value>
1645+
<value>Teleprompter</value>
16461646
</data>
16471647
<data name="LibraryDefaultAuthor" xml:space="preserve">
16481648
<value>Tu</value>

src/PrompterOne.Shared/Localization/SharedResource.pt.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1417,10 +1417,10 @@
14171417
<value>Palavras {0:N0}</value>
14181418
</data>
14191419
<data name="LibraryCardLearn" xml:space="preserve">
1420-
<value>Aprender</value>
1420+
<value>Praticar</value>
14211421
</data>
14221422
<data name="LibraryCardRead" xml:space="preserve">
1423-
<value>Ler</value>
1423+
<value>Teleprompter</value>
14241424
</data>
14251425
<data name="LibraryDefaultAuthor" xml:space="preserve">
14261426
<value>Você</value>

src/PrompterOne.Shared/Localization/SharedResource.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -592,10 +592,10 @@
592592
<value>{0:N0} words</value>
593593
</data>
594594
<data name="LibraryCardLearn" xml:space="preserve">
595-
<value>Learn</value>
595+
<value>Practice</value>
596596
</data>
597597
<data name="LibraryCardRead" xml:space="preserve">
598-
<value>Read</value>
598+
<value>Teleprompter</value>
599599
</data>
600600
<data name="LibraryDefaultAuthor" xml:space="preserve">
601601
<value>You</value>

src/PrompterOne.Shared/Localization/SharedResource.uk.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,10 +1639,10 @@
16391639
<value>{0:N0} слова</value>
16401640
</data>
16411641
<data name="LibraryCardLearn" xml:space="preserve">
1642-
<value>вчитися</value>
1642+
<value>Практика</value>
16431643
</data>
16441644
<data name="LibraryCardRead" xml:space="preserve">
1645-
<value>Прочитайте</value>
1645+
<value>Телесуфлер</value>
16461646
</data>
16471647
<data name="LibraryDefaultAuthor" xml:space="preserve">
16481648
<value>Ви</value>

src/PrompterOne.Shared/wwwroot/design/modules/library/30-bento-cards.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,7 @@
229229
}
230230
.dcard-act {
231231
flex: 1;
232+
min-width: 0;
232233
display: flex;
233234
align-items: center;
234235
justify-content: center;
@@ -242,6 +243,7 @@
242243
border: 1px solid var(--gold-10);
243244
border-radius: 10px;
244245
box-shadow: inset 0 1px 0 var(--gold-06);
246+
white-space: nowrap;
245247
}
246248
.dcard-act:hover { background: var(--gold-09); color: var(--t1); border-color: var(--gold-14); }
247249

tests/PrompterOne.Web.Tests/Library/LibraryFolderInteractionTests.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,18 @@ public void LibraryPage_ToneMetadataToggle_HidesAndRestoresToneBadge()
120120
});
121121
}
122122

123+
[Test]
124+
public void LibraryPage_CardPlaybackActionsUseClearModeLabels()
125+
{
126+
var cut = Render<LibraryPage>();
127+
128+
cut.WaitForAssertion(() =>
129+
{
130+
Assert.Equal("Practice", cut.FindByTestId(UiTestIds.Library.CardLearn(AppTestData.Scripts.DemoId)).TextContent.Trim());
131+
Assert.Equal("Teleprompter", cut.FindByTestId(UiTestIds.Library.CardRead(AppTestData.Scripts.DemoId)).TextContent.Trim());
132+
});
133+
}
134+
123135
[Test]
124136
public async Task LibraryPage_CancelsFolderOverlay_WithoutCreatingFolder()
125137
{

tests/PrompterOne.Web.UITests.Shell/AppShell/HeaderPlaybackLaunchFlowTests.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ await page.SetViewportSizeAsync(
1919

2020
await ShellRouteDriver.OpenLibraryAsync(page);
2121

22+
await Expect(page.GetByTestId(UiTestIds.Library.CardLearn(BrowserTestConstants.Scripts.QuantumId)))
23+
.ToHaveTextAsync(BrowserTestConstants.Library.PracticeActionLabel);
24+
await Expect(page.GetByTestId(UiTestIds.Library.CardRead(BrowserTestConstants.Scripts.QuantumId)))
25+
.ToHaveTextAsync(BrowserTestConstants.Library.TeleprompterActionLabel);
26+
2227
await UiInteractionDriver.ClickAndContinueAsync(
2328
page.GetByTestId(UiTestIds.Library.CardLearn(BrowserTestConstants.Scripts.QuantumId)),
2429
noWaitAfter: true);

0 commit comments

Comments
 (0)