Prioritize recording settings tab (#44)

Author: KSemenenko

src/PrompterOne.Shared/Settings/Pages/SettingsPage.Navigation.cs

@@ -13,10 +13,10 @@ public partial class SettingsPage
     [
         new(SettingsSection.Cloud, UiIconKind.Cloud, UiTextKey.SettingsNavCloud, UiTestIds.Settings.NavCloud),
         new(SettingsSection.Files, UiIconKind.Folder, UiTextKey.SettingsNavFiles, UiTestIds.Settings.NavFiles),
+        new(SettingsSection.Recording, UiIconKind.RecordTarget, UiTextKey.SettingsNavRecording, UiTestIds.Settings.NavRecording),
         new(SettingsSection.Cameras, UiIconKind.Camera, UiTextKey.SettingsNavCameras, UiTestIds.Settings.NavCameras),
         new(SettingsSection.Mics, UiIconKind.Microphone, UiTextKey.SettingsNavMicrophones, UiTestIds.Settings.NavMics),
         new(SettingsSection.Streaming, UiIconKind.ArrowRight, UiTextKey.SettingsNavStreaming, UiTestIds.Settings.NavStreaming),
-        new(SettingsSection.Recording, UiIconKind.RecordTarget, UiTextKey.SettingsNavRecording, UiTestIds.Settings.NavRecording),
         new(SettingsSection.Ai, UiIconKind.Spark, UiTextKey.SettingsNavAi, UiTestIds.Settings.NavAi),
         new(SettingsSection.Appearance, UiIconKind.Theme, UiTextKey.SettingsNavAppearance, UiTestIds.Settings.NavAppearance),
         new(SettingsSection.Language, UiIconKind.Message, UiTextKey.SettingsNavLanguage, UiTestIds.Settings.NavLanguage),

tests/PrompterOne.Web.UITests.Shell/Settings/SettingsLayoutFlowTests.cs

@@ -7,6 +7,12 @@ namespace PrompterOne.Web.UITests;
 [ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
 public sealed class SettingsLayoutFlowTests(StandaloneAppFixture fixture) : AppUiTestBase(fixture)
 {
+    private static readonly ResponsiveViewport[] SettingsNavigationReachabilityViewports =
+    [
+        new("iphone-medium-portrait", BrowserTestConstants.ResponsiveLayout.IphoneMediumWidth, BrowserTestConstants.ResponsiveLayout.IphoneMediumHeight),
+        new("ipad-mini-landscape", BrowserTestConstants.ResponsiveLayout.IpadMiniHeight, BrowserTestConstants.ResponsiveLayout.IpadMiniWidth)
+    ];
+
     private sealed class ElementBounds
     {
         public double Left { get; set; }
@@ -58,6 +64,40 @@ await UiScenarioArtifacts.CapturePageAsync(
                 BrowserTestConstants.SettingsFlow.DesktopLayoutStep);
         });
 
+    [Test]
+    public Task SettingsNavigation_PrioritizesRecordingBeforeCaptureAndStreamingControls() =>
+        RunPageAsync(async page =>
+        {
+            await ShellRouteDriver.OpenSettingsAsync(page);
+
+            var navOrder = await ReadSettingsNavigationOrderAsync(page);
+
+            await Assert.That(IndexOf(navOrder, UiTestIds.Settings.NavRecording))
+                .IsLessThan(IndexOf(navOrder, UiTestIds.Settings.NavCameras));
+            await Assert.That(IndexOf(navOrder, UiTestIds.Settings.NavRecording))
+                .IsLessThan(IndexOf(navOrder, UiTestIds.Settings.NavMics));
+            await Assert.That(IndexOf(navOrder, UiTestIds.Settings.NavRecording))
+                .IsLessThan(IndexOf(navOrder, UiTestIds.Settings.NavStreaming));
+        });
+
+    [Test]
+    public Task SettingsNavigation_RecordingPanelRemainsReachableAcrossResponsiveLayouts() =>
+        RunPageAsync(async page =>
+        {
+            foreach (var viewport in SettingsNavigationReachabilityViewports)
+            {
+                await page.SetViewportSizeAsync(viewport.Width, viewport.Height);
+                await ShellRouteDriver.OpenSettingsAsync(page, viewport.Name);
+
+                var recordingNav = page.GetByTestId(UiTestIds.Settings.NavRecording);
+                await recordingNav.ScrollIntoViewIfNeededAsync();
+                await UiInteractionDriver.ClickAndContinueAsync(recordingNav);
+
+                await Expect(page.GetByTestId(UiTestIds.Settings.RecordingPanel)).ToBeVisibleAsync(
+                    new() { Timeout = BrowserTestConstants.Timing.ExtendedVisibleTimeoutMs });
+            }
+        });
+
     private static Task<ElementBounds> ReadBoundsAsync(ILocator locator) =>
         locator.EvaluateAsync<ElementBounds>(
             """
@@ -70,4 +110,25 @@ private static Task<ElementBounds> ReadBoundsAsync(ILocator locator) =>
                 };
             }
             """);
+
+    private static Task<string[]> ReadSettingsNavigationOrderAsync(IPage page) =>
+        page.EvaluateAsync<string[]>(
+            """
+            () => Array.from(document.querySelectorAll('.set-nav [data-test]'))
+                .map(element => element.getAttribute('data-test') ?? '')
+                .filter(Boolean)
+            """);
+
+    private static int IndexOf(IReadOnlyList<string> values, string value)
+    {
+        for (var index = 0; index < values.Count; index++)
+        {
+            if (string.Equals(values[index], value, StringComparison.Ordinal))
+            {
+                return index;
+            }
+        }
+
+        throw new InvalidOperationException($"Expected settings navigation item '{value}' to be present.");
+    }
 }