Skip to content

Commit d773062

Browse files
committed
Minor format issue
1 parent 4d68bd8 commit d773062

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

build_tooling/format.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def main(type: str, in_place: bool, specific_file: str):
8383
elif type == "cpp":
8484
return lint_cpp(in_place, specific_file)
8585
else:
86-
return lint_python(in_place) or lint_cpp(in_place)
86+
return lint_python(in_place, specific_file) or lint_cpp(in_place, specific_file)
8787

8888

8989
if __name__ == "__main__":
@@ -131,8 +131,6 @@ def main(type: str, in_place: bool, specific_file: str):
131131
raise RuntimeError("Must specify --type")
132132
if args.type not in ("python", "cpp", "all"):
133133
raise RuntimeError("Invalid --type")
134-
if args.type == "all" and args.file:
135-
raise RuntimeError("Cannot specify file type when specifying a single file for formatting")
136134

137135
return_code = main(
138136
type=args.type,

python/arcticdb/version_store/_store.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3151,7 +3151,6 @@ def will_item_be_pickled(self, item, recursive_normalizers: Optional[bool] = Non
31513151
_LogLevel.WARN
31523152
)
31533153
if result and log_warning_message:
3154-
proto_cfg = self._lib_cfg.lib_desc.version.write_options
31553154
resolved_recursive_normalizers = self._is_recursive_normalizers_enabled(
31563155
**{"recursive_normalizers": recursive_normalizers}
31573156
)

python/arcticdb/version_store/library.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1041,7 +1041,7 @@ def write(
10411041
index_column=index_column,
10421042
norm_failure_options_msg="Using write_pickle will allow the object to be written. However, many operations "
10431043
"(such as date_range filtering and column selection) will not work on pickled data.",
1044-
recursive_normalizers=recursive_normalizers,
1044+
recursive_normalizers=bool(recursive_normalizers),
10451045
)
10461046

10471047
def write_pickle(
@@ -1101,7 +1101,7 @@ def write_pickle(
11011101
prune_previous_version=prune_previous_versions,
11021102
pickle_on_failure=True,
11031103
parallel=staged,
1104-
recursive_normalizers=True if recursive_normalizers else False,
1104+
recursive_normalizers=bool(recursive_normalizers),
11051105
)
11061106

11071107
@staticmethod

python/tests/unit/arcticdb/version_store/test_recursive_normalizers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def test_v2_api_pickle(arctic_library_s3, sym, recursive_normalizers, clear_quer
9090
assert "MULTI_KEY" in keys
9191
else:
9292
assert "MULTI_KEY" not in keys
93-
assert lib._nvs.is_symbol_pickled(sym) == True
93+
assert lib._nvs.is_symbol_pickled(sym)
9494

9595

9696
@pytest.mark.parametrize("read", (lambda lib, sym: lib.batch_read([sym])[sym], lambda lib, sym: lib.read(sym)))

0 commit comments

Comments
 (0)