Block staging recursive normalized data

Author: phoebusm

python/arcticdb/version_store/library.py

@@ -1034,13 +1034,20 @@ def write(
         >>> w = adb.WritePayload("symbol", df, metadata={'the': 'metadata'})
         >>> lib.write(*w, staged=True)
         """
-        if not self._nvs._is_recursive_normalizers_enabled(
+        is_recursive_normalizers_enabled = self._nvs._is_recursive_normalizers_enabled(
             **{"recursive_normalizers": recursive_normalizers}
-        ) and not self._allowed_input_type(data):
-            raise ArcticUnsupportedDataTypeException(
-                "data is of a type that cannot be normalized. Consider using "
-                f"write_pickle instead. type(data)=[{type(data)}]"
-            )
+        )
+        if not self._allowed_input_type(data):
+            if is_recursive_normalizers_enabled:
+                if staged:
+                    raise ArcticUnsupportedDataTypeException(
+                        "Staged data must be of a type that can be natively normalized"
+                    )
+            else:
+                raise ArcticUnsupportedDataTypeException(
+                    "Data is of a type that cannot be normalized. Consider using "
+                    f"write_pickle instead. type(data)=[{type(data)}]"
+                )
 
         return self._nvs.write(
             symbol=symbol,

python/tests/unit/arcticdb/version_store/test_recursive_normalizers.py

@@ -58,24 +58,29 @@ def assert_vit_equals_except_data(left, right):
     assert left.timestamp == right.timestamp
 
 
+@pytest.mark.parametrize("staged", (True, False, None))
 @pytest.mark.parametrize("lib_option", (True, False, None))
 @pytest.mark.parametrize("recursive_normalizers", (True, False, None))
-def test_v2_api(arctic_client_lmdb, sym, recursive_normalizers, clear_query_stats, lib_name, lib_option):
+def test_v2_api(
+    arctic_client_lmdb_v1_only, sym, recursive_normalizers, clear_query_stats, lib_name, lib_option, staged
+):
     if lib_option is None:
-        lib = arctic_client_lmdb.create_library(lib_name)
+        lib = arctic_client_lmdb_v1_only.create_library(lib_name)
     else:
-        lib = arctic_client_lmdb.create_library(lib_name, LibraryOptions(recursive_normalizers=lib_option))
+        lib = arctic_client_lmdb_v1_only.create_library(lib_name, LibraryOptions(recursive_normalizers=lib_option))
     lt = lib._nvs.library_tool()
     data = {"a": np.arange(5), "b": pd.DataFrame({"col": [1, 2, 3]})}
-    if (lib_option is True and recursive_normalizers is not False) or recursive_normalizers is True:
-        lib.write(sym, data, recursive_normalizers=recursive_normalizers)
+    if staged is not True and (
+        (lib_option is True and recursive_normalizers is not False) or recursive_normalizers is True
+    ):
+        lib.write(sym, data, recursive_normalizers=recursive_normalizers, staged=staged)
         assert len(lt.find_keys(KeyType.MULTI_KEY)) > 0
     else:
         with pytest.raises(ArcticUnsupportedDataTypeException) as e:
-            lib.write(sym, data, recursive_normalizers=recursive_normalizers)
+            lib.write(sym, data, recursive_normalizers=recursive_normalizers, staged=staged)
 
     if lib_option is not True:
-        arctic_client_lmdb.modify_library_option(lib, ModifiableLibraryOption.RECURSIVE_NORMALIZERS, True)
+        arctic_client_lmdb_v1_only.modify_library_option(lib, ModifiableLibraryOption.RECURSIVE_NORMALIZERS, True)
         lib.write(sym, data)