Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor KawaiiGherkin\Formatter\Example::format method's return. #9

Open
jackmakiyama opened this issue Mar 23, 2016 · 0 comments
Open

Comments

@jackmakiyama
Copy link
Contributor

The file src/Formatter/Example.php have a comment recommending refactoring the return method of KawaiiGherkin\Formatter\Example::format class:

// TODO: refactor this part
        return implode(
            array_merge(
                [
                    $this->indent(self::INDENTATION * 2) . rtrim($scenario->getExampleTable()->getKeyword()) . ":\n",
                ],
                array_map(
                    function ($arguments) {
                        return $this->indent(self::INDENTATION * 2 + 2) . trim($arguments) . "\n";
                    },
                    explode("\n", $scenario->getExampleTable()->getTableAsString())
                )
            )
        );

I removed this comment in PR #7.

jackmakiyama pushed a commit to jackmakiyama/kawaii-gherkin that referenced this issue Mar 23, 2016
@Ocramius Ocramius mentioned this issue Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant