Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

Wrong throttling implementation #127

Open
mareksuscak opened this issue Jan 14, 2020 · 1 comment
Open

Wrong throttling implementation #127

mareksuscak opened this issue Jan 14, 2020 · 1 comment

Comments

@mareksuscak
Copy link

mareksuscak commented Jan 14, 2020

Update throttling is implemented incorrectly on this line. It not only doesn't throttle the provided function at all (in fact a result of calling _spy is passed into throttle). It also creates a new function every time a scroll event is fired. This results in a huge performance hit and increased memory usage due to the number of allocations.

@mareksuscak
Copy link
Author

Submitted a PR:
#128

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant