This repository has been archived by the owner on Mar 13, 2020. It is now read-only.

Add aria-modal attribute #1

Open

ianmcburnie opened this issue Mar 13, 2019 · 0 comments

Contributor

ianmcburnie commented Mar 13, 2019 •

edited

Loading

Let's see if it's now safe (in terms of browser support/bugs) to add the aria-modal attribute.

https://www.w3.org/TR/wai-aria-1.1/#aria-modal
https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal

Before pushing the change we'll need to check for no adverse affects in the following browser/at combinations:

IE11/JAWS
IE11/Narrator
Safari/VoiceOver
Firefox/NVDA
Chrome/Chromevox

If all looks good, we should update MIND patterns too.

ianmcburnie mentioned this issue

Dialog: update ARIA attributes eBay/ebayui-core#587

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.