data
computed property on session service not always receiving content update notification
#2259
Labels
data
computed property on session service not always receiving content update notification
#2259
In multiple locations in the internal-session a deep setter is used to update
content.authenticated
. This means no "update" notification happens on thecontent
property itself, only oncontent.authenticated
. In practice this means thedata
computed property on the session service does not always update correctly when it is updated.Example of the setter: https://github.com/simplabs/ember-simple-auth/blob/3f2f60332c629f4c32743e681032bd8ea79428ce/packages/ember-simple-auth/addon/internal-session.js#L96-L100
A possible solution would be to set the entire
content
property, or to callnotifyPropertyChange
on the content property. The former is probably a more future proof solution if a refactor of internal-session ever happens with regards to tracked properties etc.The text was updated successfully, but these errors were encountered: