Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture container should not occupy space if there is no picture in a view #49

Open
JannisBush opened this issue Mar 29, 2019 · 1 comment

Comments

@JannisBush
Copy link
Contributor

If the picture-argument is empty in a view, the picture container
should not take up space

@JannisBush
Copy link
Contributor Author

JannisBush commented May 8, 2019

We could do something like this:

babe-view-stimulus-container {
    height: auto;
    max-height: 350px;
}

Now, the picture (or better) the stimulus container does not occupy any space if it is empty.
The problem is, if there are two trials in a row with different image sizes, e.g. one with 350px height and one with 200px height, the answer container will "jump" around and distract the participant. Another problem is that the fixation point won't be correctly located anymore.

I don't know how to make the stimulus container 350px height, if there is something inside and 0px height if there is nothing inside, using CSS.

Maybe, we could adjust the style (to height: 0px) in the render function of each view, if it has no picture/canvas stimuli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant