Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure deployment methods #33

Open
JannisBush opened this issue Feb 27, 2019 · 2 comments
Open

Restructure deployment methods #33

JannisBush opened this issue Feb 27, 2019 · 2 comments

Comments

@JannisBush
Copy link
Contributor

The localServer deployment currently gives this error.
Probably we only have to add another or here https://github.com/babe-project/babe-project/blob/master/src/babe-views.js#L1491

@x-ji
Copy link
Member

x-ji commented Feb 27, 2019

Actually I wonder if this deployment method is still relevant. Can we just write directLink and specify the server URL as http://localhost:4000?

@JannisBush
Copy link
Contributor Author

Yeah I also thought about that and just using directLink with http://localhost:4000, as you have suggested, should work.

I also thought about getting rid of the deployment methods for MTurk and Prolific, because they could also be used in the debug or directLink environments. We only need one additional parameter, e.g. externalDeployment, which is empty by default and you can enter MTurk, MTurkSandbox or an ProlificURL there.

JannisBush added a commit that referenced this issue Mar 29, 2019
@JannisBush JannisBush changed the title localServer: No such babe.deploy.deployMethod Restructure deployment methods Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants