Skip to content
This repository was archived by the owner on Jan 26, 2018. It is now read-only.

Commit 5a30c35

Browse files
author
Magmodules
authored
Merge pull request #3 from magmodules/development
Development
2 parents 943df07 + 409c378 commit 5a30c35

File tree

34 files changed

+364
-287
lines changed

34 files changed

+364
-287
lines changed

Block/Adminhtml/Magmodules/Header.php

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Copyright © 2016 Magmodules.eu. All rights reserved.
3+
* Copyright © 2017 Magmodules.eu. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

@@ -21,11 +21,12 @@ class Header extends Field
2121
const MODULE_SUPPORT_LINK = 'https://www.magmodules.eu/help/' . self::MODULE_CODE;
2222
const MODULE_CONTACT_LINK = 'https://www.magmodules.eu/support.html?ext=' . self::MODULE_CODE;
2323

24-
protected $general;
24+
private $general;
2525
protected $_template = 'Magmodules_TheFeedbackCompany::system/config/fieldset/header.phtml';
2626

2727
/**
2828
* Header constructor.
29+
*
2930
* @param Context $context
3031
* @param GeneralHelper $general
3132
*/
@@ -49,7 +50,8 @@ public function render(AbstractElement $element)
4950
}
5051

5152
/**
52-
* Image with extension and magento version
53+
* Image with extension and magento version.
54+
*
5355
* @return string
5456
*/
5557
public function getImage()
@@ -61,7 +63,8 @@ public function getImage()
6163
}
6264

6365
/**
64-
* Contact link for extension
66+
* Contact link for extension.
67+
*
6568
* @return string
6669
*/
6770
public function getContactLink()
@@ -70,7 +73,8 @@ public function getContactLink()
7073
}
7174

7275
/**
73-
* Support link for extension
76+
* Support link for extension.
77+
*
7478
* @return string
7579
*/
7680
public function getSupportLink()

Block/Adminhtml/Magmodules/Heading.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Copyright © 2016 Magmodules.eu. All rights reserved.
3+
* Copyright © 2017 Magmodules.eu. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

@@ -13,7 +13,8 @@ class Heading extends Field
1313
{
1414

1515
/**
16-
* Styles heading sperator
16+
* Styles heading sperator.
17+
*
1718
* @param AbstractElement $element
1819
* @return string
1920
*/

Block/Adminhtml/Magmodules/Version.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Copyright © 2016 Magmodules.eu. All rights reserved.
3+
* Copyright © 2017 Magmodules.eu. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

@@ -14,11 +14,12 @@
1414
class Version extends Field
1515
{
1616

17-
protected $general;
17+
private $general;
1818

1919
/**
2020
* Version constructor.
21-
* @param Context $context
21+
*
22+
* @param Context $context
2223
* @param GeneralHelper $general
2324
*/
2425
public function __construct(
@@ -30,8 +31,10 @@ public function __construct(
3031
}
3132

3233
/**
33-
* Version display in config
34+
* Version display in config.
35+
*
3436
* @param AbstractElement $element
37+
*
3538
* @return string
3639
*/
3740
public function render(AbstractElement $element)

Block/Adminhtml/System/Config/Form/ImportButton.php

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
<?php
22
/**
3-
* Copyright © 2016 Magmodules.eu. All rights reserved.
3+
* Copyright © 2017 Magmodules.eu. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
67
namespace Magmodules\TheFeedbackCompany\Block\Adminhtml\System\Config\Form;
78

89
use Magento\Backend\Block\Template\Context;
@@ -13,14 +14,14 @@
1314
class ImportButton extends Field
1415
{
1516

16-
protected $rev;
17-
protected $request;
17+
private $rev;
18+
private $request;
1819
protected $_template = 'Magmodules_TheFeedbackCompany::system/config/button/button.phtml';
1920

2021
/**
21-
* @param Context $context
22+
* @param Context $context
2223
* @param ReviewsHelper $revHelper
23-
* @param array $data
24+
* @param array $data
2425
*/
2526
public function __construct(
2627
Context $context,
@@ -34,6 +35,7 @@ public function __construct(
3435

3536
/**
3637
* @param AbstractElement $element
38+
*
3739
* @return string
3840
*/
3941
public function render(AbstractElement $element)
@@ -45,6 +47,7 @@ public function render(AbstractElement $element)
4547

4648
/**
4749
* @param AbstractElement $element
50+
*
4851
* @return string
4952
*/
5053
public function _getElementHtml(AbstractElement $element)
@@ -53,7 +56,8 @@ public function _getElementHtml(AbstractElement $element)
5356
}
5457

5558
/**
56-
* Returns url for review import
59+
* Returns url for review import.
60+
*
5761
* @return string
5862
*/
5963
public function getAjaxUrl()
@@ -68,7 +72,8 @@ public function getAjaxUrl()
6872
}
6973

7074
/**
71-
* Get's last imported date to display as comment msg under button
75+
* Last importdate to display as comment msg under button.
76+
*
7277
* @return mixed
7378
*/
7479
public function getLastImported()
@@ -94,6 +99,7 @@ public function getButtonHtml()
9499

95100
/**
96101
* Checks if store/website view has all oauth data.
102+
*
97103
* @return bool
98104
*/
99105
public function checkOauthData()

Block/Adminhtml/System/Config/Form/ReviewSummary.php

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
<?php
22
/**
3-
* Copyright © 2016 Magmodules.eu. All rights reserved.
3+
* Copyright © 2017 Magmodules.eu. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
67
namespace Magmodules\TheFeedbackCompany\Block\Adminhtml\System\Config\Form;
78

89
use Magento\Backend\Block\Template\Context;
@@ -13,14 +14,14 @@
1314
class ReviewSummary extends Field
1415
{
1516

16-
protected $rev;
17-
protected $request;
1817
protected $_template = 'Magmodules_TheFeedbackCompany::system/config/fieldset/summary.phtml';
18+
private $rev;
19+
private $request;
1920

2021
/**
21-
* @param Context $context
22+
* @param Context $context
2223
* @param ReviewsHelper $revHelper
23-
* @param array $data
24+
* @param array $data
2425
*/
2526
public function __construct(
2627
Context $context,
@@ -33,7 +34,8 @@ public function __construct(
3334
}
3435

3536
/**
36-
* Get review summary data from helper
37+
* Get review summary data from helper.
38+
*
3739
* @return bool
3840
*/
3941
public function getReviewSummary()
@@ -55,6 +57,7 @@ public function getReviewSummary()
5557

5658
/**
5759
* @param AbstractElement $element
60+
*
5861
* @return bool
5962
*/
6063
public function render(AbstractElement $element)
@@ -66,6 +69,7 @@ public function render(AbstractElement $element)
6669

6770
/**
6871
* @param AbstractElement $element
72+
*
6973
* @return bool
7074
*/
7175
protected function _getElementHtml(AbstractElement $element)

Block/Widget/Summary.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Copyright © 2016 Magmodules.eu. All rights reserved.
3+
* Copyright © 2017 Magmodules.eu. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

@@ -42,7 +42,8 @@ protected function _construct()
4242
}
4343

4444
/**
45-
* Rich Snippets check
45+
* Rich Snippets check.
46+
*
4647
* @return mixed
4748
*/
4849
public function getRichSnippets()
@@ -51,7 +52,8 @@ public function getRichSnippets()
5152
}
5253

5354
/**
54-
* Get summary data from review helper by storeId
55+
* Get summary data from review helper by storeId.
56+
*
5557
* @return array
5658
*/
5759
public function getSummaryData()

Controller/Adminhtml/Actions/Import.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Copyright © 2016 Magmodules.eu. All rights reserved.
3+
* Copyright © 2017 Magmodules.eu. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

@@ -24,11 +24,12 @@ class Import extends Action
2424

2525
/**
2626
* Import constructor.
27-
* @param Context $context
28-
* @param ApiModel $apiModel
27+
*
28+
* @param Context $context
29+
* @param ApiModel $apiModel
2930
* @param TypeListInterface $cacheTypeList
30-
* @param JsonFactory $resultJsonFactory
31-
* @param ReviewsHelper $revHelper
31+
* @param JsonFactory $resultJsonFactory
32+
* @param ReviewsHelper $revHelper
3233
*/
3334
public function __construct(
3435
Context $context,

Cron/ImportReviews.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Copyright © 2016 Magmodules.eu. All rights reserved.
3+
* Copyright © 2017 Magmodules.eu. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

@@ -15,6 +15,7 @@ class ImportReviews
1515

1616
/**
1717
* ImportReviews constructor.
18+
*
1819
* @param ApiModel $apiModel
1920
*/
2021
public function __construct(ApiModel $apiModel)

0 commit comments

Comments
 (0)