Skip to content

Commit af1a018

Browse files
committed
Fix Marketplace guidebook export
We now include only approved dealers in the Guidebook export and schedule changes page. Also, we no longer mark schedule items as synced when you export the schedule XLSX so you can review the full schedule without marking everything as synced.
1 parent 7e30727 commit af1a018

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

uber/site_sections/schedule_reports.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,11 @@ def schedule_guidebook_xlsx(self, out, session, new_only=False):
7373
))
7474

7575
rows = []
76-
id_list = []
77-
sync_time = str(datetime.now())
7876
query = session.query(Event).order_by('start_time')
7977
if new_only:
8078
query = query.filter(Event.last_synced['guidebook'] == None)
8179

8280
for event in query.all():
83-
id_list.append(event.id)
8481
guidebook_fields = event.guidebook_data
8582
rows.append([
8683
guidebook_fields['name'],
@@ -95,7 +92,6 @@ def schedule_guidebook_xlsx(self, out, session, new_only=False):
9592
'', '', '', '', ''
9693
])
9794

98-
sync_guidebook_models.delay('schedule', sync_time, id_list)
9995
out.writerows(header_row, rows)
10096

10197
@xlsx_file

uber/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,7 @@ def parse_guidebook_model(cls, selected_model=''):
662662

663663
@classmethod
664664
def get_guidebook_models(cls, session, selected_model=''):
665-
from uber.models import GuestBio, MITSPicture, IndieGameImage
665+
from uber.models import Group, GuestBio, MITSPicture, IndieGameImage
666666

667667
model_cls = cls.parse_guidebook_model(selected_model)
668668
model_query = session.query(model_cls)
@@ -676,7 +676,7 @@ def get_guidebook_models(cls, session, selected_model=''):
676676
model_query = model_query.filter_by(group_type=c.GUEST).outerjoin(model_cls.bio)
677677
stale_filters.append(cls.cast_jsonb_to_datetime(model_cls.last_synced['guidebook']) < GuestBio.last_updated)
678678
elif '_dealer' in selected_model:
679-
model_query = model_query.filter_by(is_dealer=True)
679+
model_query = model_query.filter(model_cls.status.in_([c.APPROVED])).filter_by(is_dealer=True)
680680
elif 'IndieGame' in selected_model:
681681
model_query = model_query.filter_by(has_been_accepted=True).outerjoin(model_cls.images)
682682
stale_filters.append(cls.cast_jsonb_to_datetime(model_cls.last_synced['guidebook']) < IndieGameImage.last_updated)

0 commit comments

Comments
 (0)