Skip to content

Condition is never met in \Magento\Framework\Escaper::escapeScriptIdentifiers #40195

@wubinworks

Description

@wubinworks

Preconditions and environment

  • Magento 2.4.x

Steps to reproduce

In \Magento\Framework\Escaper::escapeScriptIdentifiers:

Here and here, $filteredData === false will never be met since preg_replace only returns string|array|null.

See preg_replace documentation.

Expected result

Check if $filteredData is NULL.

Actual result

Check if $filteredData is false.

Additional information

Related commit.
#23988

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: Framework/EscaperIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: dev in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

Status

Ready for Development

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions