Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace </br> with a valid version of <br /> #34084

Open
3 tasks
vandijkstef opened this issue Sep 15, 2021 · 8 comments · May be fixed by #39556
Open
3 tasks

Replace </br> with a valid version of <br /> #34084

vandijkstef opened this issue Sep 15, 2021 · 8 comments · May be fixed by #39556
Assignees
Labels
Area: UI Framework Component: Code Component: Framework/Code Component: Module Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.3.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@vandijkstef
Copy link

Preconditions (*)

  1. 2.3.7

Steps to reproduce (*)

  1. Search the codebase for </br>

Expected result (*)

  1. No results, as </br> isn't a valid HTML tag. Its deprecated XHTML and basically a stray closing tag.

Actual result (*)

  1. Quite some references to </br> in various (magento) modules.

I'd opt for using <br /> over <br> as it follows the guidelines for self-closing HTML elements.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ X ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ X ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Sep 15, 2021

Hi @vandijkstef. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Sep 16, 2021

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

engcom-November commented Sep 16, 2021

Verified the issue on Magento 2.4-develop branch and the issue is reproducible.
</br> is being used in some of the Magento Modules
As per the devdocs its recommended to use <br /> but not <br>

Ex: Some files reference where </br> and <br> is being used:
app/code/Magento/Newsletter/Test/Unit/Block/Adminhtml/Template/Grid/Renderer/SenderTest.php
app/code/Magento/Analytics/etc/adminhtml/system.xml
app/code/Magento/Analytics/etc/adminhtml/system.xml
app/code/Magento/Analytics/i18n/en_US.csv
app/code/Magento/Analytics/i18n/en_US.csv
app/code/Magento/Analytics/i18n/en_US.csv
app/code/Magento/Analytics/i18n/en_US.csv
app/code/Magento/MediaGalleryUi/view/adminhtml/web/template/image/image-details.html
app/code/Magento/Customer/Controller/Adminhtml/File/Address/Upload.php
app/code/Magento/Customer/Controller/Adminhtml/File/Customer/Upload.php
app/code/Magento/Customer/Controller/Address/File/Upload.php
app/code/Magento/Customer/Test/Unit/Controller/Adminhtml/File/Address/UploadTest.php
app/code/Magento/Customer/Test/Unit/Controller/Adminhtml/File/Customer/UploadTest.php

@engcom-November engcom-November added Area: Analytics / Reporting Component: Code Component: Module Area: UI Framework Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.3.x Indicates original Magento version for the Issue report. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Area: Analytics / Reporting labels Sep 16, 2021
@engcom-November engcom-November added Component: Framework/Code and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 16, 2021
@engcom-November engcom-November added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 16, 2021
@AZiniukhin
Copy link
Contributor

@magento I am working on this

@sdzhepa sdzhepa added the Priority: P3 May be fixed according to the position in the backlog. label Sep 16, 2021
@hostep
Copy link
Contributor

hostep commented Sep 17, 2021

Maybe go with <br/> instead of <br /> to save a couple of bytes in the output?

I seem to remember from a very long time ago, that the extra space was only needed for some very old version of the Internet Explorer browser (version 5 or 6 probably). So this problem no longer needs to be circumvented in these modern days.

@engcom-November engcom-November added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 16, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7024 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Nov 16, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magentoabu
Copy link

@magento I'm working on this

@magentoabu magentoabu linked a pull request Jan 20, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI Framework Component: Code Component: Framework/Code Component: Module Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.3.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Pull Request In Progress
7 participants