Skip to content

[Issue] Updage seletor style in _message.les #39308

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #36698: Updage seletor style in _message.les


Description (*)

Adjustment in the styled element, so that there is no validation break when loading the style in email and in the frontend.

Related Pull Requests

vitinhomorais00/magento2@2.4-develop...vitinhomorais00-patch-1

Manual testing scenarios (*)

  1. Custom theme password reset flow (header and footer)
  2. Receive an email

Questions or comments

A footer and header template was created in a custom theme.
We manually took the styling from the file: lib/web/css/docs/source/_messages.less and included it in the theme.

Doing so always returns the error CSS inlining error: Warning: Uninitialized string offset 5 in /var/www/html/Magento2/vendor/sabberworm/php-css-parser/src/Value/Color.php on line 56 view the email in a provider (gmail, outlook, mailinator, etc).

We found the error in this line of code: @message-custom-icon__background: #green;
The correct one would be @message-custom-icon__background: green;

So, before it was giving an error during the compilation of the inline CSS in the email, when adjusting this styling it worked again.

We noticed that the same instruction exists in the native file and it would be interesting to have its value correct.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: Perf/FrontendAll tickets related with improving frontend performance.Component: FrontendIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Progress: PR in progressReproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions