Tax discount compensation amount not populated if product prices are configured excl. tax

[moloughlin]

Preconditions

1. Magento 2.3.4
2. Configure Sales > Tax > Calculation Settings > Catalog Prices to Excluding Tax
3. Create a shopping cart price rule which applies a discount

Steps to reproduce

1. Add items to cart
2. Apply discount code
3. Place Order
4. Inspect sales_order and sales_order_item tables, noting the 0.0000 for discount_tax_compensation_amount

Expected result

sales_order and sales_order_item tables should include non-zero discount_tax_compensation_amount values for orders where a discount amount was applied (e.g. coupon code).

This behaves correctly only if tax/calculation/price_includes_tax is set to Including Tax, example below when prices are configured to be Including Tax

MariaDB [magento2]> select entity_id, coupon_code, discount_amount, discount_tax_compensation_amount from sales_order order by entity_id desc limit 1;
+-----------+--------------+-----------------+----------------------------------+
| entity_id | coupon_code  | discount_amount | discount_tax_compensation_amount |
+-----------+--------------+-----------------+----------------------------------+
|      1088 | 40PERCENTOFF |         -6.7800 |                           0.6200 |
+-----------+--------------+-----------------+----------------------------------+
1 row in set (0.00 sec)

MariaDB [magento2]> select price_incl_tax, discount_amount,tax_amount, discount_tax_compensation_amount from sales_order_item where order_id=1088;
+----------------+-----------------+------------+----------------------------------+
| price_incl_tax | discount_amount | tax_amount | discount_tax_compensation_amount |
+----------------+-----------------+------------+----------------------------------+
|        16.9500 |          6.7800 |     0.9200 |                           0.6200 |
+----------------+-----------------+------------+----------------------------------+

Actual result

The discount_tax_compensation_amount is not calculated and saved to the DB; example below when prices are configured to be Excluding Tax:

MariaDB [magento2]> select entity_id, coupon_code, discount_amount, discount_tax_compensation_amount from sales_order order by entity_id desc limit 1;
+-----------+--------------+-----------------+----------------------------------+
| entity_id | coupon_code  | discount_amount | discount_tax_compensation_amount |
+-----------+--------------+-----------------+----------------------------------+
|      1089 | 40PERCENTOFF |         -7.4600 |                           0.0000 |
+-----------+--------------+-----------------+----------------------------------+

MariaDB [magento2]> select price_incl_tax, discount_amount,tax_amount, discount_tax_compensation_amount from sales_order_item where order_id=1089;
+----------------+-----------------+------------+----------------------------------+
| price_incl_tax | discount_amount | tax_amount | discount_tax_compensation_amount |
+----------------+-----------------+------------+----------------------------------+
|        18.6500 |          7.4600 |     0.9500 |                           0.0000 |
+----------------+-----------------+------------+----------------------------------+

[magento-deployment-service]

Thanks for opening this issue!

[m2-assistant]

Hi @moloughlin. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@moloughlin do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[ajijshekh123]

@moloughlin - Please add this issue to the below Magento guidelines.
https://github.com/magento/magento2/wiki/Issue-reporting-guidelines

Thanks.

[moloughlin]

#26598

[ajijshekh123]

Okay @moloughlin, If this issue is related to #26598 so please update me, Let me close this issue Or first you can fill issue details in a proper format then I will confirm it.

[ajijshekh123]

Hi @moloughlin,
Any update??

[magento-deployment-service]

Thanks for opening this issue!